Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge flask-graphql #37

Merged
merged 13 commits into from
May 5, 2020
Merged

Merge flask-graphql #37

merged 13 commits into from
May 5, 2020

Conversation

KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented Apr 12, 2020 •
edited
Loading

References #34, this PR merges flask-graphql library into graphql-server-core.

To install the integration with flask for example:

pip install graphql-server-core[flask]

Then you can use it by:

from grapqhl_server.flask import GraphQLView

@KingDarBoja KingDarBoja requested review from Cito and jkimbo April 12, 2020 21:28
@KingDarBoja KingDarBoja self-assigned this Apr 12, 2020
@KingDarBoja KingDarBoja added the type: feature A new feature label Apr 12, 2020
jkimbo
jkimbo requested changes Apr 26, 2020
View reviewed changes
graphql_server/__init__.py Show resolved Hide resolved
graphql_server/flask/blueprint.py Outdated Show resolved Hide resolved
tests/flask/test_graphqlview.py Outdated Show resolved Hide resolved
@KingDarBoja KingDarBoja requested a review from jkimbo April 26, 2020 19:01
jkimbo
jkimbo approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks @KingDarBoja

@KingDarBoja KingDarBoja merged commit 66b8a2b into graphql-python:master May 5, 2020
@KingDarBoja KingDarBoja deleted the merge-flask-graphql branch May 6, 2020 23:21
@KingDarBoja KingDarBoja added this to the GraphQL-Server (V3) milestone Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkimbo jkimbo jkimbo approved these changes

@Cito Cito Awaiting requested review from Cito

Assignees

@KingDarBoja KingDarBoja

Labels
type: feature A new feature
Projects
None yet
Milestone
GraphQL-Server (V3)
Development

Successfully merging this pull request may close these issues.
2 participants
@KingDarBoja @jkimbo