Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split parsing, validation and execution (#43) #53

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Split parsing, validation and execution (#43) #53

merged 1 commit into from
Jul 11, 2020

Conversation

Cito
Copy link
Member

@Cito Cito commented Jul 11, 2020 •
edited
Loading

Instead of graphql()/graphql_sync() we now call execute() directly.

This solves not only #43 but also allows adding custom validation rules and limiting the number of reported errors.

@Cito
Split parsing, validation and execution (graphql-python#43)
353fbc7 
Instead of graphql()/graphql_sync() we now call execute() directly.

This also allows adding custom validation rules and limiting the number
of reported errors.
@Cito Cito requested a review from KingDarBoja July 11, 2020 20:45
KingDarBoja
KingDarBoja approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@KingDarBoja KingDarBoja added type: optimization A code change that improves performance type: tests Adding missing or correcting existing tests labels Jul 11, 2020
@KingDarBoja KingDarBoja linked an issue Jul 11, 2020 that may be closed by this pull request
Queries are parsed twice #43
Closed
@KingDarBoja KingDarBoja merged commit 90cfb09 into graphql-python:master Jul 11, 2020
@Cito Cito deleted the use-execute-function branch July 11, 2020 21:01
@KingDarBoja KingDarBoja added this to the GraphQL-Server (V3) milestone Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
type: optimization A code change that improves performance type: tests Adding missing or correcting existing tests
Projects
None yet
Milestone
GraphQL-Server (V3)
Development

Successfully merging this pull request may close these issues.

Queries are parsed twice
2 participants
@Cito @KingDarBoja