Modernize #36
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| module.exports = { | ||
| parser: '@typescript-eslint/parser', | ||
| plugins: ['@typescript-eslint'], | ||
| parserOptions: { | ||
| project: './tsconfig.json' | ||
| }, | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'prettier', | ||
| 'prettier/@typescript-eslint', | ||
| 'plugin:prettier/recommended' | ||
| ], | ||
| rules: { | ||
| 'interface-name': 0, | ||
| 'object-literal-sort-keys': 0, | ||
| 'no-increment-decrement': 0, | ||
| '@typescript-eslint/no-explicit-any': 0, | ||
| '@typescript-eslint/no-unused-vars': 0, | ||
| '@typescript-eslint/explicit-module-boundary-types': 0, | ||
| '@typescript-eslint/no-non-null-assertion': 0 | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| name: Continuous Integration | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| jobs: | ||
| test-and-lint: | ||
| name: Run tests and lint | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Install node | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: '14.x' | ||
| - run: yarn install | ||
| - run: yarn lint | ||
| - run: yarn typecheck | ||
| - run: yarn test | ||
| - run: yarn build | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,46 @@ | ||
| { | ||
| "name": "@graphql-query-rewriter/core", | ||
| "version": "0.0.1", | ||
| "description": "", | ||
| "keywords": [ | ||
| "graphql", | ||
| "query", | ||
| "rewriter", | ||
| "ast", | ||
| "schema" | ||
| ], | ||
| "main": "dist/index.js", | ||
| "types": "dist/index.d.ts", | ||
| "files": [ | ||
| "dist" | ||
| ], | ||
| "author": "David Chanin <chanindav@gmail.com>", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/ef-en/graphql-query-rewriter" | ||
|
There was a problem hiding this comment. this URL isn't correct - should be https://github.com/graphql-query-rewriter/core |
||
| }, | ||
| "license": "MIT", | ||
| "engines": { | ||
| "node": ">=10.0.0" | ||
| }, | ||
| "scripts": { | ||
|
There was a problem hiding this comment. I think it's probably fine to get rid of rollup, just out of curiosity why remove it? Is it related to updating the node version? This wall all from https://github.com/alexjoverm/typescript-library-starter There was a problem hiding this comment. Yeah I saw the similarities, I reality I never saw something similar to that setup. If you look around all libs that mainly support node all use similar tsconfig and output commonjs code with types near the js code. So unless we need to do something fancy there is no need at this point to support es5/umd/other types of import. |
||
| "lint": "eslint --ext .ts,.js src/ test/", | ||
| "prebuild": "rimraf dist && rimraf docs", | ||
| "build": "tsc -p tsconfig.build.json && typedoc --tsconfig tsconfig.build.json", | ||
| "test": "jest --coverage", | ||
| "test:watch": "jest --coverage --watch", | ||
| "deploy-docs": "ts-node tools/gh-pages-publish", | ||
| "report-coverage": "cat ./coverage/lcov.info | coveralls", | ||
| "commit": "git-cz", | ||
| "semantic-release": "semantic-release", | ||
| "semantic-release-prepare": "ts-node tools/semantic-release-prepare", | ||
| "typecheck": "tsc -p tsconfig.build.json --noEmit" | ||
| }, | ||
| "lint-staged": { | ||
| "{src,test}/**/*.ts": [ | ||
| "prettier --write" | ||
| ] | ||
| }, | ||
| "jest": { | ||
| "transform": { | ||
| ".(ts|tsx)": "ts-jest" | ||
|
|
@@ -76,52 +72,45 @@ | |
| "prettier": { | ||
| "singleQuote": true | ||
| }, | ||
| "husky": { | ||
| "hooks": { | ||
| "pre-commit": "lint-staged", | ||
| "commit-msg": "commitlint -E HUSKY_GIT_PARAMS" | ||
| } | ||
| }, | ||
| "commitlint": { | ||
| "extends": [ | ||
| "@commitlint/config-conventional" | ||
| ] | ||
| }, | ||
| "devDependencies": { | ||
| "@commitlint/cli": "11.0.0", | ||
| "@commitlint/config-conventional": "11.0.0", | ||
| "@types/express": "4.17.11", | ||
| "@types/jest": "26.0.20", | ||
| "@types/node": "14.14.25", | ||
| "@typescript-eslint/eslint-plugin": "4.14.1", | ||
| "@typescript-eslint/parser": "4.14.1", | ||
| "colors": "1.4.0", | ||
| "coveralls": "3.1.0", | ||
| "dedent-js": "1.0.1", | ||
| "eslint": "7.19.0", | ||
| "eslint-config-prettier": "7.2.0", | ||
| "eslint-plugin-prettier": "3.3.1", | ||
| "graphql": "15.5.0", | ||
| "husky": "4.3.8", | ||
| "jest": "26.6.3", | ||
| "lint-staged": "10.5.3", | ||
| "prettier": "2.2.1", | ||
| "rimraf": "3.0.2", | ||
| "semantic-release": "17.3.7", | ||
| "shelljs": "0.8.4", | ||
| "ts-jest": "26.5.0", | ||
| "ts-node": "9.1.1", | ||
| "typedoc": "0.20.20", | ||
| "typescript": "4.1.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "graphql": "^0.12.0 || ^0.13.0 || ^14.0.0 || ^15.0.0" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "extends": ["config:base"], | ||
| "timezone": "America/New_York", | ||
| "schedule": ["before 10am on Friday"], | ||
| "lockFileMaintenance": { | ||
| "enabled": true, | ||
| "schedule": "before 10am on Friday" | ||
| }, | ||
| "packageRules": [ | ||
| { | ||
| "updateTypes": ["minor", "patch", "pin", "digest"], | ||
| "automerge": true | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to add
yarn report-coverageand set up coveralls for GH actions