Skip to content

Update to the June 2018 GraphQL spec #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LegNeato opened this issue Jun 12, 2018 · 7 comments
Closed

Update to the June 2018 GraphQL spec #196

LegNeato opened this issue Jun 12, 2018 · 7 comments

Comments

@LegNeato
Copy link
Member

A new spec is out (https://github.com/facebook/graphql/releases/tag/June2018). It looks like a lot of our error handling questions / behaviors have been clarified among other things.

@theduke
Copy link
Member

theduke commented Jul 19, 2018

We should come up with a checklist of what we have to implement and have issues for everything.

@LegNeato
Copy link
Member Author

#219 switched from data to extensions for custom error data.

@dvic
Copy link
Contributor

dvic commented Oct 5, 2018

@LegNeato I think it would be useful to have a test suite based on https://github.com/graphql-cats/graphql-cats. That project seems to cover many scenario's, I think also beyond the June 2018 spec, but at least then we have an idea of what is supported and what is not.

I'm not sure what the implementation would be exactly (a simple dynamic schema executor based on the scenarios'?) but the project is useful at least as a point of reference :)

@theduke
Copy link
Member

theduke commented Oct 5, 2018

@dvic I already made an issue for this a while ago.

#245

@dvic
Copy link
Contributor

dvic commented Oct 5, 2018

@LegNeato Ah nice, next time I'll make sure to do a search ;) Maybe I have this weekend time to have a look at it to see what we can do with it.

@tyranron
Copy link
Member

tyranron commented May 7, 2020

@LegNeato I guess this has been fixed in #631?

@LegNeato
Copy link
Member Author

LegNeato commented Jul 8, 2020

Yes, this should be fixed.

@LegNeato LegNeato closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants