rust-lang/rust#70814: code using quote generates false lint warnings for unused_braces in juniper::graphql_object

[grantperry]

One liner function definitions causes a lint warning about unused braces. Removing said braces, creates invalid rust.
rust-lang/rust#70814

warning: unnecessary braces around block return value
   --> src/models/user.rs:137:63
    |
137 |     fn ticket(&self, context : &SharedContext) -> Option<Ticket> { self.get_ticket(context) }
    |                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces

Minimum example

#[juniper::graphql_object]
impl Obj {
    fn ticket(&self) -> &str { &self.field }
}

I expect no lint errors.

cargo 1.44.0-nightly (ebda5065e 2020-04-16)

[LegNeato]

Looks like this is going to be fixed in clippy.

[Igosuki]

More than a year later and still hasn't been fixed in clippy

[Igosuki]

As a reference anyone landing here, add a linter allowance in the mod #![allow(unused_braces)]

[tyranron]

@Igosuki this should be already resolved in master due to using #[automatically_derived] attribute in #971.

[Igosuki]

Cool, I'll wait for it to land as a release Le ven. 3 sept. 2021 à 11:39, Kai Ren ***@***.***> a écrit :

…

@Igosuki <https://github.com/Igosuki> this should be already resolved in master due to using #[automatically_derived] attribute in #971 <#971>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDFBQ2TNCIPE4BXQ4FGGDUACJTTANCNFSM4MLWTARQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[twiclo]

I'm experiencing this on juniper 0.15.10. Any suggestions? (Other than the allow macro)

[tyranron]

@twiclo unfortunately, juniper 0.15.10 doesn't include #971, it's only in master for the moment.