Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphQL October 2021] Support directives on variable definitions (#1000) #1005

Merged
merged 4 commits into from
Dec 21, 2021
Merged

[GraphQL October 2021] Support directives on variable definitions (#1000) #1005

merged 4 commits into from
Dec 21, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 14, 2021 •
edited by tyranron
Loading

Part of #1000

Synopsis

RFC

Solution

Support directives on variable definitions. Although there is no way for now to use this feature, at least it will provide better error messages.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Dec 14, 2021
@ilslv ilslv self-assigned this Dec 14, 2021
@ilslv ilslv marked this pull request as draft December 14, 2021 13:37
@ilslv ilslv mentioned this pull request Dec 14, 2021
Closed
6 tasks
@ilslv
Merge branch 'master' into 1000-directive-on-var-derinition
3f4ad2e 
# Conflicts:
#	juniper/CHANGELOG.md
#	juniper/src/schema/model.rs
#	juniper/src/tests/schema_introspection.rs
@ilslv
Correction
0e522a6
@ilslv ilslv marked this pull request as ready for review December 21, 2021 10:15
@ilslv
Copy link
Member Author

ilslv commented Dec 21, 2021 •
edited by tyranron
Loading

FCM

Support directives on variables definitions (#1005, #1000)

@ilslv ilslv changed the title Draft: [GraphQL October 2021] Support directives on variable definitions (#1000) [GraphQL October 2021] Support directives on variable definitions (#1000) Dec 21, 2021
@ilslv ilslv requested a review from tyranron December 21, 2021 13:23
@tyranron tyranron merged commit eb83b60 into master Dec 21, 2021
@tyranron tyranron deleted the 1000-directive-on-var-derinition branch December 21, 2021 17:14
@tyranron tyranron added this to the 0.16.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron