Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow interfaces to implement other interfaces (#1000) #1028

Merged
merged 150 commits into from
Jun 27, 2022
Merged

Allow interfaces to implement other interfaces (#1000) #1028

merged 150 commits into from
Jun 27, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Feb 22, 2022 •
edited by tyranron
Loading

Part of #1000

Synopsis

GraphQL October 2021 spec allows interfaces to implement other interfaces.

Solution

Allow interfaces to implement other interfaces and add compile-time asserts to ensure correctness.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

ilslv and others added 30 commits December 20, 2021 07:44
@ilslv
WIP
01d7cb8
@ilslv
WIP
205cfcd
@ilslv
WIP (with IsSubtype)
928cb9c
@ilslv
WIP (It looks like we're onto something)
3dad162
@ilslv
WIP (return to const assertions)
af04486
@ilslv
Make chrono scalars similar to the time
4ae8c5d
@ilslv
Remove FixedOffset scalar
279ae22
@ilslv
Corrections
bba4af8
@ilslv
Merge branch 'master' into chrono-scalars
ecf9179
@ilslv
It's alive!
15e527f
@ilslv
Merge branch 'master' into 1000-new-interfaces
cb9cad5
@ilslv
Use Field inside object's field resolver
7a78f9e
@ilslv
Add async object fields
5c2087c
@ilslv
Fix
e9c6046
@tyranron
Corrections
f2275a4
@ilslv
Fix Wrapped type for tuple with context
0739c3e
@ilslv
WIP (Make graphql_interface_new attribute work)
263d544
@ilslv
WIP (move to the new tests volume 1)
f4c48a6
@ilslv
WIP (move to the new tests volume 2)
a1df387
@ilslv
WIP (move to the new tests volume 3)
5040d68
@ilslv
WIP (move to the new tests volume 4)
f5533e3
@ilslv
WIP (move to the new tests volume 5)
527325c
@ilslv
WIP (move to the new tests volume 5)
704f079
@ilslv
WIP (refactor)
b84009e
@ilslv
WIP (refactor)
11345f7
@ilslv
WIP (moving to readable const asserts)
5e7230f
@ilslv
WIP (finally good const assert message)
d17ba4f
@ilslv
WIP (corrections)
8cb9b81
@ilslv
WIP (pretty field arguments check)
116cdd9
@ilslv
WIP (pretty subtype check)
7bd8c73
ilslv added 3 commits March 25, 2022 09:15
@ilslv
Merge branch 'master' into derive-interface-on-structs
a89162c
@ilslv
Merge branch 'derive-interface-on-structs' into interface-inheritance
30558b4 
# Conflicts:
#	juniper_codegen/src/graphql_interface/attr.rs
#	juniper_codegen/src/graphql_interface/derive.rs
#	juniper_codegen/src/graphql_interface/mod.rs
@ilslv
Corrections
678d00a
@ilslv ilslv mentioned this pull request Mar 28, 2022
Closed
6 tasks
@ilslv ilslv marked this pull request as ready for review March 28, 2022 11:20
@ilslv
Copy link
Member Author

ilslv commented Mar 28, 2022

FCM

Allow interfaces to implement other interfaces (#1028, #1000)

@tyranron tyranron added this to the 0.16.0 milestone Apr 13, 2022
@tyranron tyranron mentioned this pull request May 31, 2022
Draft
26 tasks
@tyranron tyranron marked this pull request as draft May 31, 2022 11:59
ilslv added 6 commits June 24, 2022 16:15
@ilslv
Corrections
d5bbdd7
@ilslv
Merge branch 'master' into interface-inheritance
c9643ab 
# Conflicts:
#	juniper_codegen/src/graphql_interface/attr.rs
#	juniper_codegen/src/graphql_interface/derive.rs
#	juniper_codegen/src/graphql_interface/mod.rs
#	juniper_codegen/src/result.rs
#	tests/codegen/fail/interface/struct/attr_implementers_duplicate_pretty.stderr
#	tests/codegen/fail/interface/struct/attr_missing_field.stderr
#	tests/codegen/fail/interface/struct/derive_implementers_duplicate_pretty.stderr
#	tests/codegen/fail/interface/struct/derive_missing_field.stderr
#	tests/codegen/fail/interface/trait/implementers_duplicate_pretty.stderr
#	tests/codegen/fail/interface/trait/missing_field.stderr
#	tests/integration/src/codegen/interface_attr_struct.rs
#	tests/integration/src/codegen/interface_attr_trait.rs
#	tests/integration/src/codegen/interface_derive.rs
#	tests/integration/src/codegen/mod.rs
@ilslv
Corrections
bc2cb20
@ilslv
Fix integration tests
0240ab4
@ilslv
Merge branch 'master' into interface-inheritance
f7be617 
# Conflicts:
#	juniper/src/integrations/bson.rs
#	juniper_codegen/src/graphql_enum/derive.rs
#	juniper_codegen/src/graphql_enum/mod.rs
#	juniper_codegen/src/lib.rs
#	tests/codegen/fail/enum/derive_name_double_underscored.rs
#	tests/codegen/fail/enum/derive_name_double_underscored.stderr
#	tests/codegen/fail/enum/derive_no_fields.stderr
#	tests/codegen/fail/enum/derive_variant_with_field.rs
#	tests/codegen/fail/enum/derive_variant_with_field.stderr
#	tests/codegen/fail/enum/derive_wrong_item.rs
#	tests/codegen/fail/enum/derive_wrong_item.stderr
#	tests/codegen/fail/interface/struct/attr_missing_field.stderr
#	tests/codegen/fail/interface/struct/derive_missing_field.stderr
#	tests/codegen/fail/interface/trait/missing_field.stderr
#	tests/integration/src/codegen/enum_derive.rs
@ilslv
Corrections
2832e35
@ilslv ilslv changed the title Draft: Allow interfaces to implement other interfaces (#1000) Allow interfaces to implement other interfaces (#1000) Jun 27, 2022
@ilslv ilslv marked this pull request as ready for review June 27, 2022 05:51
@ilslv ilslv requested a review from tyranron June 27, 2022 07:23
@tyranron tyranron enabled auto-merge (squash) June 27, 2022 11:56
@tyranron tyranron merged commit 9ca2364 into master Jun 27, 2022
@tyranron tyranron deleted the interface-inheritance branch June 27, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron