Add local_inner_macros to all helper macros
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubnt-intrepid
force-pushed
the
local-inner-macros
branch
from
a922bc4 to
18de075
Compare
It allows to use the Rust2018-style macro imports correctly:
```rust
use juniper::graphql_object;
graphql_object!(User: () |&self| { ... });
```
In the future when dropping compatibility with pre-2018 compilers,
it is able to be replaced with the explicit `$crate` prefixes instead of
`local_inner_macros`.
In `macro_rules!` with the annotation `local_inner_macros`, all of macro calls
are transformed into `$crate::builtin!(...)` (See [1] for details).
Therefore, name resolutions of built-in macros are not perfomed correctly.
To avoid such situation, some helper macros are introduced to make built-in
macros be interpreted as crate-local macros.
[1]: rust-lang/rust#53464 (comment)
ubnt-intrepid
force-pushed
the
local-inner-macros
branch
from
18de075 to
4a009a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 89.89% 89.88% -0.01%
==========================================
Files 96 96
Lines 18167 18153 -14
==========================================
- Hits 16331 16317 -14
Misses 1836 1836
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to use the Rust2018-style macro imports correctly:
In the future when dropping compatibility with pre-2018 compilers, it is able to be replaced with the explicit
$crateprefixes instead oflocal_inner_macros.Notes
In
macro_rules!with the annotationlocal_inner_macros, all of macro calls are transformed into$crate::builtin!(...)(rust-lang/rust#53464 (comment)). Therefore, name resolutions of built-in macros are not perfomed correctly.To avoid such situation, some helper macros are introduced to make built-in macros be interpreted as crate-local macros.