Remove GraphQLType impl for unit () type #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 105 105
Lines 15373 15373
=======================================
Hits 13279 13279
Misses 2094 2094
Continue to review full report at Codecov.
|
This impl can cause weird runtime errors and serves no real practical purpose. Removing the impl is a breaking change but is the only way to error out at runtime.
theduke
force-pushed
the
remove-graphqltype-unit-impl
branch
from
185f023 to
aafddc5
Compare
LegNeato
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impl can cause weird runtime errors and serves
no real practical purpose.
Removing the impl is a breaking change but is the only
way to error out at runtime.
Closes #161.