Add note on complex fields impl block in doc #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 111 111
Lines 15958 15958
=======================================
Hits 13678 13678
Misses 2280 2280Continue to review full report at Codecov.
|
davidpdrsn
reviewed
Dec 13, 2019
| @@ -25,6 +25,14 @@ impl Person { | |||
| } | |||
| } | |||
|
|
|||
| // Note that this syntax generates an impl block for the GraphQLType trait, | |||
| // the base impl of your struct can still be writen like usual: | |||
There was a problem hiding this comment.
Sounds good but I would tweak the wording a bit:
// Note that this syntax generates an implementation of the GraphQLType trait,
// the base impl of your struct can still be written like usual:
|
Thanks for the PR! |
LegNeato
pushed a commit
that referenced
this pull request
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a small note in doc to avoid confusion about
implblock for complex fields.See #482