Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(juniper_graphql_ws): correct null deserialization issue #738

Merged
merged 1 commit into from
Aug 14, 2020
Merged

fix(juniper_graphql_ws): correct null deserialization issue #738

merged 1 commit into from
Aug 14, 2020

Conversation

lightdiscord
Copy link
Contributor

Closes #735

cc @LegNeato

LegNeato
LegNeato approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the high-quality report, PR, and test! 🍻👏

@LegNeato LegNeato merged commit fdad97a into graphql-rust:master Aug 14, 2020
@lightdiscord lightdiscord deleted the bug-fix/735 branch August 15, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegNeato LegNeato LegNeato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

juniper_graphql_ws: serde deserialization error with null values
2 participants
@lightdiscord @LegNeato