Add support for browser environments #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secret sauce of this library is `enqueuePostPromiseJob`, which relies on node.js behavior of process.nextTick to behave correctly. Browsers must use a macro-task to achieve similarly correct behavior, though it may have performance implications.
shivijais
reviewed
Feb 19, 2018
| } | ||
| resolvedPromise.then(() => process.nextTick(fn)); | ||
| } : | ||
| setImmediate || setTimeout; |
There was a problem hiding this comment.
@leebyron This will throw error in browsers which do not support setImmediate. SetImmediate polyfill is mandatory for this code to work. Something like this would be better
(typeof setImmediate !== 'undefined' ? setImmediate : setTimeout)
There was a problem hiding this comment.
Aye, same. Care here and saw this. Is this still not addressed?
To anyone using CoreJS, a workaround:
import 'core-js/web/immediate';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secret sauce of this library is
enqueuePostPromiseJob, which relies on node.js behavior of process.nextTick to behave correctly. Browsers must use a macro-task to achieve similarly correct behavior, though it may have performance implications.Closes #112