Deactivate Prime fonction when cache is disabled #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently used DataLoader and I implemented in one of my program. After implementing a lot of them I saw that I needed a huge amount of ram using the default Map implementation.
I decided to disable cache for all implementation. Nevertheless, the prime functions that I used in my code were still caching and increased the amount of ram.
After investigation, it seems that the prime function doesn't look for option.cached.
The pull request is there to solve this issue.
To reproduce the issue, you can see the section Loading by alternative keys (See README.md) and add caching false to
userByIDLoader. You will see that usingusernameLoaderit will cache some values even if you don't want to.