Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor batching logic #220

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Refactor batching logic #220

merged 1 commit into from
Nov 15, 2019

Conversation

leebyron
Copy link
Contributor

This is a non-breaking refactor of DataLoader's batching logic meant to simplify the load() method, put a more understandable abstraction in place which can be a target for more complex behavior (such as #113)

It replaces the concept of a LoaderQueue with a Batch. It moves all logic for creating this datastructure into a dedicated function, and moves the logic for splitting a batch (maxBatchSize) to batch creation time rather than batch dispatch time, which simplifies the dispatch logic.

@leebyron leebyron merged commit b5d7bf5 into master Nov 15, 2019
@leebyron leebyron deleted the batch-object branch November 15, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant