[FIX] Fix case where priming an Error results in UnhandledPromiseRejection #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
fix-prime-error
branch
from
7849f01 to
a426e1e
Compare
…edPromiseRejection
leebyron
force-pushed
the
fix-prime-error
branch
2 times, most recently
from
7d03ded to
931eb51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the cache stores Promises instead of values, we need to store a rejected promise for error cases.
In the case we want to prime such an error, a new rejected Promise is created and stored for later access. This is an unhandled promise rejection. However this is an intentionally unhandled rejection since it is stored for later access.
However this also masks another minor bug (#224) where loading that primed Error but not handling it should result in an UnhandledPromiseRejection but does not.