Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme badge to use GitHub CI instead of unused Travis #352

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

andrew-demb
Copy link
Contributor

While observing if there are any other mentions for unused Travis I found that it's mentioned here

# When Travis CI publishes to NPM, the published files are available in the root

But this script was probably not used at all because for publishing in NPM, it used Github action without prepublish script

jobs:
release:
name: Release
uses: the-guild-org/shared-config/.github/workflows/release-stable.yml@main
with:
releaseScript: release
nodeVersion: 16
secrets:
githubToken: ${{ secrets.GITHUB_TOKEN }}
npmToken: ${{ secrets.NPM_TOKEN }}

Should I drop all mentions about prepublish script?


Another observation - another abandoned badge - about code coverage (current badge leads to coveralls, but in workflow codecov is used).

To fix this badge it's needed to copy the link from codecov repo settings https://docs.codecov.com/docs/status-badges

https://app.codecov.io/github/graphql/dataloader/commits?branch=main

Should I drop coveralls badge at all?

Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@saihaj saihaj merged commit 003c045 into graphql:main Feb 11, 2024
1 check passed
@andrew-demb andrew-demb deleted the github-ci-build-badge branch February 11, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants