Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows for specifying the maxBatchSize #42

Merged
merged 1 commit into from
Sep 23, 2016
Merged

Allows for specifying the maxBatchSize #42

merged 1 commit into from
Sep 23, 2016

Conversation

shimeez
Copy link
Contributor

@shimeez shimeez commented Sep 7, 2016

Closes #35

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2c3165e on bonsaico:mshim/maxBatchSize into 68a2a2e on facebook:master.

@leebyron
Copy link
Contributor

Thanks for this contribution!

I'm curious if it makes sense to include this in the core library, or if it makes more sense to suggest that users of this library do this themselves. I can see arguments for keeping the library simple, but also can see how leaving this up users of the library may lead to less clear code.

@leebyron leebyron merged commit baf07db into graphql:master Sep 23, 2016
@leebyron
Copy link
Contributor

Let's go with it.

leebyron added a commit that referenced this pull request Sep 23, 2016
@leebyron
Follow-ups to #42
a972eb5 
- Add maxBatchSize to type definitions.
- Add some additional comments.
- Optimize common path.
- Fix lint and type checking errors.
@shimeez shimeez deleted the mshim/maxBatchSize branch October 4, 2016 15:57
@jaslong jaslong mentioned this pull request Jul 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shimeez @coveralls @leebyron