This repository was archived by the owner on Mar 20, 2023. It is now read-only.
[GraphiQL] Allow to pass cookies from the client #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to back a auth middleware in-front of the GraphiQL UI.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Master and a deployed release currently have |
|
This is great. |
brandonbloom
added a commit
to brandonbloom/graphiql-app
that referenced
this pull request
Oct 12, 2016
Fixes skevy#40. See this corresponding change in express-graphql: graphql/express-graphql#30
skevy
pushed a commit
to skevy/graphiql-app
that referenced
this pull request
Oct 15, 2016
Fixes #40. See this corresponding change in express-graphql: graphql/express-graphql#30
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to back a auth middleware in-front of the GraphiQL UI.
Some background info:
I wanted to deploy this GraphiQL dashboard to a production app. But, I can't deploy it without even a simple auth system.
So, I implemented a simple basic-auth middleware and add a cookie (with some auth-key) for other requests. (specially from the
fetch). But, by default fetch does not forward cookies. We need to add an option to do it.Here I've only enabled
same-originpolicy. So, it's cause no harm.