Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Use a named function for the middleware over an anonymous #415

Merged
merged 2 commits into from
Feb 18, 2018
Merged

Use a named function for the middleware over an anonymous #415

merged 2 commits into from
Feb 18, 2018

Conversation

oliviertassinari
Copy link
Contributor

@oliviertassinari oliviertassinari commented Feb 9, 2018

It's making the investigation of performance issues easier.
@IvanGoncharov IvanGoncharov merged commit 8b15ffb into graphql:master Feb 18, 2018
@oliviertassinari oliviertassinari deleted the patch-1 branch February 18, 2018 22:46
@oliviertassinari
Copy link
Contributor Author

@IvanGoncharov Thanks for https://github.com/APIs-guru/graphql-voyager by the way, very useful!

@IvanGoncharov
Copy link
Member

@oliviertassinari Makes a lot of sense 👍
I just renamed graphql to graphqlMiddleware to prevent confusion with:
https://github.com/graphql/graphql-js/blob/master/src/graphql.js#L71

@IvanGoncharov
Copy link
Member

@oliviertassinari This PR included in 0.6.12 📦
More details in Released notes.

Thanks for APIs-guru/graphql-voyager by the way, very useful!

Thanks. Developers who wrote Graphviz (it's 🚀 science) are true heroes 👏 we just wrapped their code into shiny UI 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants