Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Fix flow type error #516

Closed
wants to merge 1 commit into from
Closed

Fix flow type error #516

wants to merge 1 commit into from

Conversation

HsuTing
Copy link

@HsuTing HsuTing commented Jun 27, 2019

mixed had changed, after flow@0.98.0:

  • mixed refined to an array produces a read-only array.
  • mixed refined to an object produces a read-only object.

@HsuTing HsuTing changed the title fix(parseGraphQLParams): fix flow type error Fix flow type error Jun 27, 2019
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Jun 28, 2019
IvanGoncharov added a commit to graphql/graphql-js that referenced this pull request Jun 28, 2019
@IvanGoncharov
Copy link
Member

@HsuTing Thanks for reporting it and for detailed investigation 👍
I fixed it in #518 by making query variables read-only both in express-graphql and graphql-js.

@HsuTing HsuTing deleted the fix-flow branch June 30, 2019 16:10
@HsuTing
Copy link
Author

HsuTing commented Jun 30, 2019

@IvanGoncharov I'm glad to hear that. Thank for your help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants