Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Make dependencies up-to-date, needed to fix bug: https://phabricator.babeljs.io/T2212 #79

Closed
wants to merge 6 commits into from

Conversation

bkinsey808
Copy link
Contributor

So, I ran into an issue with the dist/index.js file. I was trying to consume this project as a dependency in a typescript project. Apparently the older version of babel was incorrectly inserting

module.exports = exports["default"]

into the compiled code, which was causing this issue: microsoft/TypeScript#5565

@ghost
Copy link

ghost commented Apr 30, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost
Copy link

ghost commented Apr 30, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Apr 30, 2016
@calebmer calebmer mentioned this pull request May 1, 2016
@bkinsey808
Copy link
Contributor Author

I am struggling trying to get mocha to work with babel 6. Sorry about the mess of commits. Still have not found a solution. Can anybody help?

…nfortunately, tests still do not pass. Can any mocha expert pls help?
@bkinsey808
Copy link
Contributor Author

Asked for help on a mocha forum: https://groups.google.com/forum/#!topic/mochajs/sywjRY2WqKc

@leebyron
Copy link
Contributor

I backed out the changes to supertest and supertest-as-promised and then tests passed. My guess is that supertest changed the way that testing interface works in a breaking way.

@leebyron
Copy link
Contributor

leebyron commented May 27, 2016

Merged in 4044ec9

@leebyron leebyron closed this May 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants