enable unicorn/no-array-push-push rule (#3047)

.changeset/two-ravens-care.md

@@ -0,0 +1,5 @@
+---
+'monaco-graphql': patch
+---
+
+combining multiple Array#push() into one call

.eslintrc.js

@@ -228,6 +228,7 @@ module.exports = {
     'sort-imports': 0,
     'symbol-description': 1,
 
+    'unicorn/no-array-push-push': 'error',
     'import/no-extraneous-dependencies': 'error',
     'import/no-duplicates': 'error',
     'import/no-named-as-default': 'error',

packages/graphiql-react/src/explorer/components/__tests__/doc-explorer.spec.tsx

@@ -118,6 +118,7 @@ describe('DocExplorer', () => {
       useEffect(() => {
         if (context.explorerNavStack.length === 1) {
           context.push({ name: 'Query', def: Query });
+          // eslint-disable-next-line unicorn/no-array-push-push -- false positive, push here accept only 1 argument
           context.push({ name: 'field', def: field });
         }
       }, [context]);
@@ -184,6 +185,7 @@ describe('DocExplorer', () => {
       useEffect(() => {
         if (context.explorerNavStack.length === 1) {
           context.push({ name: 'Query', def: Query });
+          // eslint-disable-next-line unicorn/no-array-push-push -- false positive, push here accept only 1 argument
           context.push({ name: 'field', def: field });
         }
       }, [context]);

packages/monaco-graphql/src/languageFeatures.ts

@@ -72,32 +72,27 @@ export class DiagnosticsAdapter {
       }
     };
 
-    this._disposables.push(editor.onDidCreateModel(onModelAdd));
-    this._disposables.push({
-      dispose: () => {
-        clearTimeout(onChangeTimeout);
-      },
-    });
     this._disposables.push(
+      editor.onDidCreateModel(onModelAdd),
+      {
+        dispose: () => {
+          clearTimeout(onChangeTimeout);
+        },
+      },
       editor.onWillDisposeModel(model => {
         onModelRemoved(model);
       }),
-    );
-    this._disposables.push(
       editor.onDidChangeModelLanguage(event => {
         onModelRemoved(event.model);
         onModelAdd(event.model);
       }),
-    );
-
-    this._disposables.push({
-      dispose: () => {
-        for (const key in this._listener) {
-          this._listener[key].dispose();
-        }
+      {
+        dispose: () => {
+          for (const key in this._listener) {
+            this._listener[key].dispose();
+          }
+        },
       },
-    });
-    this._disposables.push(
       defaults.onDidChange(() => {
         editor.getModels().forEach(model => {
           if (getModelLanguageId(model) === this.defaults.languageId) {