extends plugin:import/recommended and fix warnings

.changeset/cold-doors-arrive.md

@@ -0,0 +1,12 @@
+---
+'cm6-graphql': patch
+'codemirror-graphql': patch
+'graphiql': patch
+'graphql-language-service': patch
+'graphql-language-service-cli': patch
+'graphql-language-service-server': patch
+'monaco-graphql': patch
+'vscode-graphql-execution': patch
+---
+
+extends `plugin:import/recommended` and fix warnings

.eslintrc.js

@@ -22,7 +22,6 @@ module.exports = {
     react: {
       version: 'detect',
     },
-    'import/extensions': ['.js', '.jsx', '.ts', '.tsx'],
   },
   // https://github.com/sindresorhus/globals/blob/master/globals.json
   env: {
@@ -36,6 +35,7 @@ module.exports = {
 
   extends: [
     'eslint:recommended',
+    'plugin:import/recommended',
     'plugin:import/typescript',
     'plugin:react/recommended',
     'plugin:react-hooks/recommended',
@@ -227,10 +227,9 @@ module.exports = {
     'sort-imports': 0,
     'symbol-description': 1,
 
-    // import (https://github.com/benmosher/eslint-plugin-import)
-    // 'import/no-unresolved': [2, { modules: 'es6' }],
-    'import/no-cycle': 0,
-    'import/no-extraneous-dependencies': 1,
+    'import/no-extraneous-dependencies': 'error',
+    'import/no-duplicates': 'error',
+    'import/no-named-as-default': 'error',
     'prefer-object-spread': 'error',
     // react rules
     'react/no-unused-state': 'error',
@@ -264,10 +263,10 @@ module.exports = {
     'jest/no-conditional-expect': 0,
   },
 
-  plugins: ['import', '@typescript-eslint'],
+  plugins: ['@typescript-eslint'],
 
   overrides: [
-    // Cypress plugin, global, etc only for cypress directory
+    // Cypress plugin, global, etc. only for cypress directory
     // https://github.com/cypress-io/eslint-plugin-cypress
     // cypress clashes with jest expect()
     {
@@ -291,13 +290,6 @@ module.exports = {
         'jest/no-conditional-expect': 0,
       },
     },
-    {
-      // Converted from 'dependencies' options in ancient config
-      files: ['**/spec/**', '**/sample-*/**'],
-      rules: {
-        'import/no-cycle': 0,
-      },
-    },
     {
       // Resources are typically our helper scripts; make life easier there
       files: ['resources/**', '**/resources/**', 'scripts/**'],
@@ -322,5 +314,22 @@ module.exports = {
         'no-alert': 'off',
       },
     },
+    // Ignore imported dependencies from tests files
+    {
+      files: ['**/__tests__/**', 'webpack.config.js'],
+      rules: {
+        'import/no-extraneous-dependencies': 'off',
+      },
+    },
+    // Allow import `vscode` package
+    {
+      files: [
+        'packages/vscode-graphql/**',
+        'packages/vscode-graphql-execution/**',
+      ],
+      rules: {
+        'import/no-unresolved': ['error', { ignore: ['vscode'] }],
+      },
+    },
   ],
 };

examples/cm6-graphql-legacy-parcel/package.json

@@ -1,5 +1,5 @@
 {
-  "name": "example-cm6-graphql-parcel",
+  "name": "example-cm6-graphql-legacy-parcel",
   "version": "1.1.10-alpha.8",
   "license": "MIT",
   "description": "GraphiQL Parcel Example",

examples/cm6-graphql-parcel/src/index.ts

@@ -4,6 +4,7 @@ import { history } from '@codemirror/commands';
 import { autocompletion, closeBrackets } from '@codemirror/autocomplete';
 import { bracketMatching, syntaxHighlighting } from '@codemirror/language';
 import { oneDarkHighlightStyle, oneDark } from '@codemirror/theme-one-dark';
+// eslint-disable-next-line import/no-unresolved
 import { graphql } from 'cm6-graphql';
 import query from './sample-query';
 import { TestSchema } from './testSchema';

examples/graphiql-parcel/src/index.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import ReactDOM from 'react-dom';
-import GraphiQL from 'graphiql';
+import { GraphiQL } from 'graphiql';
 
 const App = () => (
   <GraphiQL

examples/graphiql-webpack/src/index.jsx

@@ -2,10 +2,11 @@ import 'regenerator-runtime/runtime.js';
 
 import * as React from 'react';
 import { render } from 'react-dom';
-import GraphiQL from 'graphiql';
+import { GraphiQL } from 'graphiql';
 import { useExplorerPlugin } from '@graphiql/plugin-explorer';
 import { useExporterPlugin } from '@graphiql/plugin-code-exporter';
 
+// eslint-disable-next-line import/no-unresolved
 import 'graphiql/graphiql.css';
 import '@graphiql/plugin-explorer/dist/style.css';
 import '@graphiql/plugin-code-exporter/dist/style.css';

examples/monaco-graphql-webpack/src/editors.ts

@@ -3,7 +3,7 @@ import * as monaco from 'monaco-editor';
 // NOTE: using loader syntax because Yaml worker imports editor.worker directly and that
 // import shouldn't go through loader syntax.
 // @ts-ignore
-import GraphQLWorker from 'monaco-graphql/esm/graphql.worker';
+import GraphQLWorker from 'monaco-graphql/esm/graphql.worker'; // eslint-disable-line import/default
 
 const GRAPHQL_LANGUAGE_ID = 'graphql';
 

functions/schema-demo.js

@@ -1,5 +1,6 @@
 /* example using https://github.com/awslabs/aws-serverless-express */
 const express = require('express');
+// eslint-disable-next-line import/no-extraneous-dependencies
 const { graphqlHTTP } = require('express-graphql');
 const awsServerlessExpress = require('aws-serverless-express');
 const schema = require('../packages/graphiql/test/schema');

package.json

@@ -6,10 +6,7 @@
   "workspaces": {
     "packages": [
       "packages/*",
-      "examples/graphiql-webpack",
-      "examples/monaco-graphql-webpack",
-      "examples/monaco-graphql-react-vite",
-      "examples/cm6-graphql-parcel"
+      "examples/*"
     ]
   },
   "lint-staged": {
@@ -120,6 +117,7 @@
     "cypress": "^4.7.0",
     "eslint": "^8.16.0",
     "eslint-config-prettier": "^8.5.0",
+    "eslint-import-resolver-typescript": "^3.5.2",
     "eslint-plugin-cypress": "^2.12.1",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^26.4.5",

packages/cm6-graphql/__tests__/test.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-unresolved
 import { graphqlLanguage } from '../dist/index.js';
 import { fileTests } from '@lezer/generator/dist/test';
 

packages/cm6-graphql/rollup.config.js

@@ -1,4 +1,5 @@
 import esbuild from 'rollup-plugin-esbuild';
+// eslint-disable-next-line import/no-unresolved
 import { lezer } from '@lezer/generator/rollup';
 
 export default {

packages/codemirror-graphql/src/__tests__/hint-test.ts

@@ -20,7 +20,6 @@ import {
   __Schema,
   __Type,
 } from 'graphql';
-import '../hint';
 import { GraphQLHintOptions, IHint, IHints } from '../hint';
 import '../mode';
 import {

packages/graphiql/cypress/plugins/cy-ts-preprocessor.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 const wp = require('@cypress/webpack-preprocessor');
 
 const webpackOptions = {

packages/graphiql/package.json

@@ -54,6 +54,7 @@
     "@graphiql/toolkit": "^0.8.0",
     "entities": "^2.0.0",
     "graphql-language-service": "^5.1.0",
+    "regenerator-runtime": "0.13.11",
     "markdown-it": "^12.2.0"
   },
   "peerDependencies": {

packages/graphiql/test/afterDevServer.js

@@ -1,4 +1,4 @@
-/* eslint-disable react-hooks/rules-of-hooks */
+// eslint-disable-next-line import/no-extraneous-dependencies
 const { useServer } = require('graphql-ws/lib/use/ws');
 const { Server: WebSocketServer } = require('ws');
 const schema = require('./schema');
@@ -8,5 +8,6 @@ module.exports = function afterDevServer(_app, _server, _compiler) {
     path: '/subscriptions',
     port: 8081,
   });
+  // eslint-disable-next-line react-hooks/rules-of-hooks
   useServer({ schema }, wsServer);
 };

packages/graphql-language-service-cli/src/client.ts

@@ -7,11 +7,10 @@
  *
  */
 
-import { GraphQLSchema } from 'graphql';
+import { GraphQLSchema, buildSchema, buildClientSchema } from 'graphql';
 
 import invariant from 'assert';
 import fs from 'fs';
-import { buildSchema, buildClientSchema } from 'graphql';
 import {
   getAutocompleteSuggestions,
   getDiagnostics,

packages/graphql-language-service-server/package.json

@@ -52,6 +52,7 @@
     "nullthrows": "^1.0.0",
     "vscode-jsonrpc": "^8.0.1",
     "vscode-languageserver": "^8.0.1",
+    "vscode-languageserver-types": "^3.17.2",
     "vscode-uri": "^3.0.2"
   },
   "devDependencies": {

packages/graphql-language-service-server/src/GraphQLLanguageService.ts

@@ -16,6 +16,9 @@ import {
   ValidationRule,
   FieldNode,
   GraphQLError,
+  Kind,
+  parse,
+  print,
 } from 'graphql';
 
 import {
@@ -51,7 +54,6 @@ import {
   SymbolKind,
 } from 'vscode-languageserver-types';
 
-import { Kind, parse, print } from 'graphql';
 import { Logger } from './Logger';
 
 const {

packages/graphql-language-service-server/src/MessageProcessor.ts

@@ -32,9 +32,6 @@ import type {
   DidSaveTextDocumentParams,
   DidOpenTextDocumentParams,
   DidChangeConfigurationParams,
-} from 'vscode-languageserver/node';
-
-import type {
   Diagnostic,
   CompletionItem,
   CompletionList,

packages/graphql-language-service-server/src/index.ts

@@ -16,4 +16,3 @@ export { Logger } from './Logger';
 export * from './GraphQLCache';
 export * from './parseDocument';
 export * from './findGraphQLTags';
-export * from './stringToHash';

packages/graphql-language-service/src/interface/autocompleteUtils.ts

@@ -7,8 +7,12 @@
  *
  */
 
-import { GraphQLField, GraphQLSchema, GraphQLType } from 'graphql';
-import { isCompositeType } from 'graphql';
+import {
+  GraphQLField,
+  GraphQLSchema,
+  GraphQLType,
+  isCompositeType,
+} from 'graphql';
 import {
   SchemaMetaFieldDef,
   TypeMetaFieldDef,

packages/graphql-language-service/src/interface/getAutocompleteSuggestions.ts

@@ -31,17 +31,6 @@ import {
   isEnumType,
   isInputObjectType,
   isOutputType,
-} from 'graphql';
-
-import {
-  CompletionItem,
-  AllTypeInfo,
-  IPosition,
-  CompletionItemKind,
-  InsertTextFormat,
-} from '../types';
-
-import {
   GraphQLBoolean,
   GraphQLEnumType,
   GraphQLInputObjectType,
@@ -61,6 +50,14 @@ import {
   parse,
 } from 'graphql';
 
+import {
+  CompletionItem,
+  AllTypeInfo,
+  IPosition,
+  CompletionItemKind,
+  InsertTextFormat,
+} from '../types';
+
 import {
   CharacterStream,
   onlineParser,

packages/graphql-language-service/src/interface/getDiagnostics.ts

@@ -19,10 +19,9 @@ import {
   print,
   validate,
   NoDeprecatedCustomRule,
+  parse,
 } from 'graphql';
 
-import { parse } from 'graphql';
-
 import { CharacterStream, onlineParser } from '../parser';
 
 import { Range, validateWithCustomRules, Position } from '../utils';

packages/graphql-language-service/src/parser/onlineParser.ts

@@ -27,10 +27,6 @@
  *
  */
 
-import {
-  LexRules as LexRulesType,
-  ParseRules as ParseRulesType,
-} from './Rules';
 import CharacterStream from './CharacterStream';
 import { State, Token, Rule, RuleKind } from './types';
 
@@ -39,8 +35,8 @@ import { Kind } from 'graphql';
 
 export type ParserOptions = {
   eatWhitespace: (stream: CharacterStream) => boolean;
-  lexRules: Partial<typeof LexRulesType>;
-  parseRules: typeof ParseRulesType;
+  lexRules: Partial<typeof LexRules>;
+  parseRules: typeof ParseRules;
   editorConfig: { [name: string]: any };
 };
 
@@ -234,7 +230,7 @@ const SpecialParseRules = {
 
 // Push a new rule onto the state.
 function pushRule(
-  rules: typeof ParseRulesType,
+  rules: typeof ParseRules,
   state: State,
   ruleKind: RuleKind,
 ): void {
@@ -346,7 +342,7 @@ function unsuccessful(state: State): void {
 
 // Given a stream, returns a { kind, value } pair, or null.
 function lex(
-  lexRules: Partial<typeof LexRulesType>,
+  lexRules: Partial<typeof LexRules>,
   stream: CharacterStream,
 ): Token | null | undefined {
   const kinds = Object.keys(lexRules);

packages/monaco-graphql/package.json

@@ -36,6 +36,7 @@
   },
   "peerDependencies": {
     "graphql": "^15.5.0 || ^16.0.0",
-    "monaco-editor": "^0.20.0"
+    "monaco-editor": "^0.20.0",
+    "prettier": "^2.8.0 || ^3.0.0"
   }
 }

packages/monaco-graphql/src/GraphQLWorker.ts

@@ -106,7 +106,7 @@ export class GraphQLWorker {
         ),
       };
     } catch (err) {
-      // eslint-disable-next-line
+      // eslint-disable-next-line no-console
       console.error(err);
       return null;
     }

packages/vscode-graphql-execution/package.json

@@ -110,6 +110,7 @@
     "graphql-tag": "2.12.6",
     "graphql-ws": "5.10.0",
     "@whatwg-node/fetch": "0.2.8",
+    "wonka": "4.0.15",
     "ws": "8.8.1",
     "graphql": "16.6.0",
     "nullthrows": "1.1.1"