enable no-negated-condition and no-else-return rules (#2931)

graphql · Dec 2, 2022 · f7addb2 · f7addb2
1 parent c44ea4f
commit f7addb2
Show file tree

Hide file tree

Showing 28 changed files with 607 additions and 498 deletions.
diff --git a/.changeset/chilled-mayflies-heal.md b/.changeset/chilled-mayflies-heal.md
@@ -0,0 +1,12 @@
+---
+'cm6-graphql': patch
+'codemirror-graphql': patch
+'@graphiql/react': patch
+'@graphiql/toolkit': patch
+'graphql-language-service': patch
+'graphql-language-service-server': patch
+'monaco-graphql': patch
+'vscode-graphql-execution': patch
+---
+
+enable `no-negated-condition` and `no-else-return` rules
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -77,7 +77,7 @@ module.exports = {
     'no-caller': 1,
     'no-case-declarations': 0,
     'no-div-regex': 1,
-    'no-else-return': 0,
+    'no-else-return': ['error', { allowElseIf: false }],
     'no-empty-function': 0,
     'no-eq-null': 0,
     'no-eval': 1,
@@ -189,7 +189,7 @@ module.exports = {
     'no-inline-comments': 0,
     'no-lonely-if': 0,
     'no-mixed-operators': 0,
-    'no-negated-condition': 0,
+    'no-negated-condition': 'error',
     'no-nested-ternary': 0,
     'no-new-object': 1,
     'no-plusplus': 0,