Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let people use the beta of React 0.14 as a peer dependency #14

Merged
merged 1 commit into from
Aug 31, 2015

Conversation

steveluscher
Copy link
Contributor

No description provided.

@leebyron
Copy link
Contributor

Does "0.13 - 0.14" work?

@zpao
Copy link

zpao commented Aug 26, 2015

You've got some crazy version strings going on, combining ~ with .x. If you use ^0.13 || ^0.14.0-beta1 that will take all of 0.13 and all of 0.14 >= 0.14.0-beta1 (you might actually want beta3, your call). That will also pick up stable versions of 0.14 when they are out.

> require('semver').satisfies('0.14.1', '^0.13 || ^0.14.0-beta1')
true

http://semver.npmjs.com/ is also a good tool for visualizing published versions.

@zpao
Copy link

zpao commented Aug 26, 2015

And for reference, it seems like prereleases don't get caught in a bunch of ranges, eg 0.13 - 0.14 won't allow betas

> require('semver').satisfies('0.14.0-beta3', '0.13 - 0.14')
false

@steveluscher
Copy link
Contributor Author

Thanks! Updated.

@fson
Copy link
Contributor

fson commented Aug 29, 2015

This would be nice to get in the next release, as it would also enable using GraphiQL with the relay-starter-kit more easily.

leebyron added a commit that referenced this pull request Aug 31, 2015
Let people use the beta of React 0.14 as a peer dependency
@leebyron leebyron merged commit cad3b32 into master Aug 31, 2015
@leebyron
Copy link
Contributor

Whoa, I didn't know about that semver visualization, thanks @zpao it's super helpful to know about.

@leebyron leebyron deleted the react-0-14-beta-dep branch August 31, 2015 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants