Fix onToggleDocs behavior. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if the onToggleDocs prop is not provided, GraphiQL errors. Let's check for the presence of that function before trying to call it.
ghost
added
the
This was referenced Jun 9, 2016
|
@asiandrummer I don't usually ping on PR's but I thought I'd ping on this one simply because docs are fully broken in the latest release. |
|
any updates on this? |
Merged
|
Thanks @skevy. I totally missed that one... |
|
I'm sorry to be late in responding guys - I'll be sure to be faster in responses in the future. This lgtm; thanks for the fix @skevy!! |
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Jun 5, 2019
Remove broken top-level build scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if the onToggleDocs prop is not provided, GraphiQL errors. Let's check for the presence of that function before trying to call it.