Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] add support for React >=0.14.8 #155

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

zaneclaes
Copy link

Hey @leebyron, @spikebrehm and I were able to get GraphiQL successfully running on React 14.8 at Airbnb, but NPM install complains because it it has a peer dependency for React 15. Can you confirm that GraphiQL works properly with React 14?

@ghost
Copy link

ghost commented Jul 29, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the CLA Signed label Jul 29, 2016
@ghost
Copy link

ghost commented Jul 29, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron
Copy link
Contributor

This seems good to me but cc'ing @asiandrummer to investigate the build failures.

@ghost ghost added the CLA Signed label Jul 30, 2016
@asiandrummer
Copy link
Contributor

Hi @zaneclaes - I've just fixed the build failures by upgrading react to v0.15.3 and including a mocked Range implementation. Could you please rebase to master?
The branch conflicts are caused by me and is probably complaining that I've changes the peer dependency versions from 0.15.1 to 0.15.3. Apologies for that

@ghost ghost added the CLA Signed label Aug 1, 2016
@asiandrummer asiandrummer merged commit 65e1ecd into graphql:master Aug 1, 2016
@asiandrummer
Copy link
Contributor

Thanks again!

@zaneclaes
Copy link
Author

Thanks for the quick turnaround, @asiandrummer and @leebyron!

@zaneclaes zaneclaes deleted the zkc-react-14.8 branch August 1, 2016 20:29
@zaneclaes
Copy link
Author

@asiandrummer looks like you released 0.7.4 just before this got merged. Could you let me know when you can publish a new version?

@asiandrummer
Copy link
Contributor

asiandrummer commented Aug 1, 2016

@zaneclaes - sure thing! I think I'll create another release very soon, supposedly by the end of this week. I'd like to attend to #152 and include it in 0.7.5.

@zaneclaes
Copy link
Author

@asiandrummer any updates, here? We've been blocked for > 2 weeks.

@asiandrummer
Copy link
Contributor

@zaneclaes I'm really sorry for the delay - just released v0.7.5.

acao pushed a commit to acao/graphiql that referenced this pull request Jun 1, 2019
…transform-es2015-function-name-6.24.1

Update babel-plugin-transform-es2015-function-name to the latest version 🚀
acao pushed a commit to acao/graphiql that referenced this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants