Improved error handling for variables parsing #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #168, this PR improves error reporting for variable parsing:
Here I handle 3 general cases:
null
/undefined
or an empty string - variables set tonull
"Variables are not a JSON object."
Along the way I also noticed that
"Fetcher did not return Promise or Observable."
error was not reported correctly. Existing code was setting the state, but after_fetchQuery
is finished, the state is immediately reset once again. It works for all other scenarios because they all set the state in an async callbacks, but it's not that case with"Fetcher did not return Promise or Observable."
error. In order to solve the issue, I refactored this bit withthrow
/try
/catch
.