Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling validation (diagnostics) #2382

Merged
merged 1 commit into from
May 1, 2022
Merged

Conversation

acao
Copy link
Member

@acao acao commented May 1, 2022

users receive duplicate validation messages when using our LSP alongside existing validation tools like graphql-eslint

resolves #2363 and partially solves #2309

@changeset-bot
Copy link

changeset-bot bot commented May 1, 2022

🦋 Changeset detected

Latest commit: 0c8a699

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #2382 (dfe8daf) into main (2d91916) will decrease coverage by 0.94%.
The diff coverage is 74.09%.

❗ Current head dfe8daf differs from pull request most recent head 0c8a699. Consider uploading reports for the commit 0c8a699 to get more accurate results

@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
- Coverage   65.70%   64.76%   -0.95%     
==========================================
  Files          85       81       -4     
  Lines        5106     5330     +224     
  Branches     1631     1723      +92     
==========================================
+ Hits         3355     3452      +97     
- Misses       1747     1874     +127     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de55db4...0c8a699. Read the comment docs.

@acao
Copy link
Member Author

acao commented May 1, 2022

@dotansimha gotta admit, this canary github action is SO fast! I pushed an amended commit with a changeset and watched the comment change within ~1s !! 👁️ 👁️

@acao
Copy link
Member Author

acao commented May 1, 2022

awkward commit I needed to add to pass CI, for some reason over the weekend, our @babel/preset-env version resolved in a way that requires us to explicitly specifiy the nullish coalescing plugin. May cherry-pick into a seperate PR for cleaner git history

users receive duplicate validation messages when using our LSP alongside existing validation tools like `graphql-eslint`
@acao acao merged commit 1bea864 into main May 1, 2022
@acao acao deleted the LSP-disable-validation branch May 1, 2022 10:44
@github-actions github-actions bot mentioned this pull request May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature - Option to disable "validate against schema"
2 participants