-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling validation (diagnostics) #2382
Conversation
a74baf0
to
ee7d8b7
Compare
🦋 Changeset detectedLatest commit: 0c8a699 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are not available as canary, since there are no linked |
ee7d8b7
to
d51fe75
Compare
Codecov Report
@@ Coverage Diff @@
## main #2382 +/- ##
==========================================
- Coverage 65.70% 64.76% -0.95%
==========================================
Files 85 81 -4
Lines 5106 5330 +224
Branches 1631 1723 +92
==========================================
+ Hits 3355 3452 +97
- Misses 1747 1874 +127
Partials 4 4
Continue to review full report at Codecov.
|
@dotansimha gotta admit, this canary github action is SO fast! I pushed an amended commit with a changeset and watched the comment change within ~1s !! 👁️ 👁️ |
awkward commit I needed to add to pass CI, for some reason over the weekend, our |
users receive duplicate validation messages when using our LSP alongside existing validation tools like `graphql-eslint`
dfe8daf
to
0c8a699
Compare
users receive duplicate validation messages when using our LSP alongside existing validation tools like
graphql-eslint
resolves #2363 and partially solves #2309