Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vscode publishing with changesets #2395

Merged
merged 1 commit into from
May 9, 2022
Merged

fix vscode publishing with changesets #2395

merged 1 commit into from
May 9, 2022

Conversation

acao
Copy link
Member

@acao acao commented May 9, 2022

This gets vscode-graphql publishing properly in concert with changesets.

When the workspace is marked private: true, we can't expect postpublish to fire, but postversion should!

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2022

🦋 Changeset detected

Latest commit: 3320aa6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao
Copy link
Member Author

acao commented May 9, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

1 similar comment
@acao
Copy link
Member Author

acao commented May 9, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #2395 (3320aa6) into main (2d91916) will decrease coverage by 0.93%.
The diff coverage is 73.98%.

@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   65.70%   64.77%   -0.94%     
==========================================
  Files          85       81       -4     
  Lines        5106     5331     +225     
  Branches     1631     1724      +93     
==========================================
+ Hits         3355     3453      +98     
- Misses       1747     1874     +127     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/ToolbarMenu.tsx 2.50% <ø> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca7f9e...3320aa6. Read the comment docs.

@acao acao merged commit f7f1e90 into main May 9, 2022
@acao acao deleted the postversion-vscode branch May 9, 2022 13:55
@acao acao mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant