Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use graphql-config legacy mode by default #2519

Merged
merged 2 commits into from
Jun 30, 2022
Merged

use graphql-config legacy mode by default #2519

merged 2 commits into from
Jun 30, 2022

Conversation

acao
Copy link
Member

@acao acao commented Jun 25, 2022

since many of the folks using .graphqlrc files still are dealing with abstractions that don't make it easy to provide LSP settings for config request, i think we should just make this the default for now.

since many of the folks using `.graphqlrc` files still are dealing with abstractions that don't make it easy to provide LSP settings for config request, i think we should just make this the default for now.
@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2022

🦋 Changeset detected

Latest commit: b86dfad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
graphql-language-service-cli Patch
vscode-graphql Patch
graphql-language-service-server Patch
graphql-language-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

codemirror-graphql@1.3.3-canary-0ac0349e.0
graphiql@1.9.10-canary-0ac0349e.0
@graphiql/react@0.4.3-canary-0ac0349e.0
graphql-language-service@5.0.7-canary-0ac0349e.0
graphql-language-service-cli@3.2.29-canary-0ac0349e.0
graphql-language-service-server@2.7.28-canary-0ac0349e.0
monaco-graphql@1.1.3-canary-0ac0349e.0

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #2519 (b86dfad) into main (2d91916) will increase coverage by 2.64%.
The diff coverage is 23.64%.

@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
+ Coverage   65.70%   68.35%   +2.64%     
==========================================
  Files          85       71      -14     
  Lines        5106     4181     -925     
  Branches     1631     1387     -244     
==========================================
- Hits         3355     2858     -497     
+ Misses       1747     1318     -429     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.76% <5.76%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 46.98% <66.66%> (ø)
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822fba6...b86dfad. Read the comment docs.

@acao acao merged commit de5d5a0 into main Jun 30, 2022
@acao acao deleted the graphql-config-legacy branch June 30, 2022 17:00
@acao acao mentioned this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant