-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure compatible version of vscode-languageserver-protocol resolved #2546
Conversation
|
|
@acao sorry for the ping but could you please check this PR? |
@xuanduc987 thanks for making this PR! if you add a changeset to the PR, it will publish a canary and you can install it and see if it fixes the issue! I am quite busy tonight and it is 8:00pm here but if you can confirm it fixes it for you locally, i can do a quick merge & release |
oh hm, will need to test in |
Codecov Report
@@ Coverage Diff @@
## main #2546 +/- ##
==========================================
+ Coverage 65.70% 69.45% +3.74%
==========================================
Files 85 71 -14
Lines 5106 4154 -952
Branches 1631 1375 -256
==========================================
- Hits 3355 2885 -470
+ Misses 1747 1264 -483
- Partials 4 5 +1
Continue to review full report at Codecov.
|
@xuanduc987 you can rebase for a fix to the cspell failure, that is an unrelated issue to your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that with a local build, this change works fine for me when using vscode-graphql
. I don't have the ability to confirm it works for nvim.coc
yet, but I hope to give that local setup another try soon, hopefully tomorrow!
wait what just happened... I rebased your branch and the PR was closed automatically? so weird either way I borked something, re-opening because this fix needs to get to nvim.coc users! y'all have been waiting to long! |
@xuanduc987 so, I can re-create the PR but then I can't give you git message footer Otherwise, you can re-create the PR and we will get this bugfix shipped soon! Again, apologies for messing this up. |
Between MINOR version of vscode-languageserver-protocol, the version of vscode-jsonrpc that it depends on changed in MAJOR version.
Thus, this PR try to ensure the user of this package use compatible version of vscode-languageserver-protocol and vscode-jsonrpc.
I think this will fixes #2230