Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure compatible version of vscode-languageserver-protocol resolved #2546

Closed
wants to merge 0 commits into from

Conversation

xuanduc987
Copy link

Between MINOR version of vscode-languageserver-protocol, the version of vscode-jsonrpc that it depends on changed in MAJOR version.

Thus, this PR try to ensure the user of this package use compatible version of vscode-languageserver-protocol and vscode-jsonrpc.

I think this will fixes #2230

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 7, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xuanduc987 / name: Duc Nghiem Xuan (1499f44)

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2022

⚠️ No Changeset found

Latest commit: 737d418

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xuanduc987
Copy link
Author

@acao sorry for the ping but could you please check this PR?

@acao
Copy link
Member

acao commented Jul 8, 2022

@xuanduc987 thanks for making this PR! if you add a changeset to the PR, it will publish a canary and you can install it and see if it fixes the issue! I am quite busy tonight and it is 8:00pm here but if you can confirm it fixes it for you locally, i can do a quick merge & release

@acao
Copy link
Member

acao commented Jul 8, 2022

oh hm, will need to test in vscode-graphql as well. if you happen to have vscode installed, and open it in vscode and run the "extension" task or what have you, you can manually check the vscode-graphql extension and make sure it works with this change as well.

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #2546 (1499f44) into main (2d91916) will increase coverage by 3.74%.
The diff coverage is 23.12%.

@@            Coverage Diff             @@
##             main    #2546      +/-   ##
==========================================
+ Coverage   65.70%   69.45%   +3.74%     
==========================================
  Files          85       71      -14     
  Lines        5106     4154     -952     
  Branches     1631     1375     -256     
==========================================
- Hits         3355     2885     -470     
+ Misses       1747     1264     -483     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.76% <5.76%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 46.98% <66.66%> (ø)
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea15939...1499f44. Read the comment docs.

@acao
Copy link
Member

acao commented Jul 8, 2022

@xuanduc987 you can rebase for a fix to the cspell failure, that is an unrelated issue to your PR

Copy link
Member

@acao acao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that with a local build, this change works fine for me when using vscode-graphql. I don't have the ability to confirm it works for nvim.coc yet, but I hope to give that local setup another try soon, hopefully tomorrow!

@acao
Copy link
Member

acao commented Jul 8, 2022

wait what just happened... I rebased your branch and the PR was closed automatically? so weird

either way I borked something, re-opening because this fix needs to get to nvim.coc users! y'all have been waiting to long!

@acao
Copy link
Member

acao commented Jul 8, 2022

@xuanduc987 so, I can re-create the PR but then I can't give you git message footer Co-authored-by: credit (and thus github repo contribution credit) without at least a github ofusicated email or whatever identifier.

Otherwise, you can re-create the PR and we will get this bugfix shipped soon! Again, apologies for messing this up.

@acao acao mentioned this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lsp server doesn't start using coc.vim
2 participants