Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for graphql in python snippets #2556

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

qw-in
Copy link
Contributor

@qw-in qw-in commented Jul 8, 2022

fixes #2547

image

  • Add support for syntax highlighting in python files
  • Supports #graphql comment
  • Support gql(""" syntax (including with a line break)

Looking into adding tests, but that could be a separate pr. Thanks for having a look!


I'm working on the CLA

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

🦋 Changeset detected

Latest commit: ff2ed94

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@acao
Copy link
Member

acao commented Jul 10, 2022

thank you @qw-in! also are you able to add a changeset for this wonderful and very welcome feature?

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #2556 (ff2ed94) into main (2d91916) will increase coverage by 3.74%.
The diff coverage is 23.12%.

@@            Coverage Diff             @@
##             main    #2556      +/-   ##
==========================================
+ Coverage   65.70%   69.45%   +3.74%     
==========================================
  Files          85       71      -14     
  Lines        5106     4154     -952     
  Branches     1631     1375     -256     
==========================================
- Hits         3355     2885     -470     
+ Misses       1747     1264     -483     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.76% <5.76%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 46.98% <66.66%> (ø)
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3304606...ff2ed94. Read the comment docs.

@qw-in
Copy link
Contributor Author

qw-in commented Jul 10, 2022

@acao wow, somehow I completely missed that entire first comment - only saw the CLA one 😅 . I'll go sort out a changeset

@acao
Copy link
Member

acao commented Jul 11, 2022

@qw-in apologies there is lots of clutter in the bot PR comments! also seems this Linux Foundation CLA bot is still being buggy :/

@qw-in
Copy link
Contributor Author

qw-in commented Jul 11, 2022

@acao I was waiting on getting the corporate CLA set up. All good now 😄

@acao
Copy link
Member

acao commented Jul 12, 2022

great @qw-in! thanks for taking care of that boilerplate detail. merging and releasing now!

@acao acao merged commit e04dd9c into graphql:main Jul 12, 2022
@acao acao mentioned this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode-graphql] Any interest in python support?
2 participants