Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: support vscode multi-root workspaces (#2594)" #2612

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

Foo-x
Copy link
Contributor

@Foo-x Foo-x commented Aug 1, 2022

This reverts commit 5827977.

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022

⚠️ No Changeset found

Latest commit: f527e41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #2612 (f527e41) into main (2d91916) will increase coverage by 3.82%.
The diff coverage is 23.84%.

@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
+ Coverage   65.70%   69.53%   +3.82%     
==========================================
  Files          85       71      -14     
  Lines        5106     4201     -905     
  Branches     1631     1408     -223     
==========================================
- Hits         3355     2921     -434     
+ Misses       1747     1275     -472     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.66% <5.66%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 47.61% <66.66%> (+0.63%) ⬆️
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3cbb3...f527e41. Read the comment docs.

@acao
Copy link
Member

acao commented Aug 1, 2022

@Foo-x thank you! sorry we had to do this temporarily. as soon as I merge this, feel free to open a re-creation of this PR and I will merge it in the order that makes sense this time haha

@acao acao merged commit 621253d into graphql:main Aug 1, 2022
acao added a commit that referenced this pull request Aug 1, 2022
@Foo-x Foo-x deleted the revert-multi-root branch August 1, 2022 09:16
acao added a commit that referenced this pull request Oct 8, 2022
acao added a commit that referenced this pull request Oct 10, 2022
Introduces multi-root workspaces support using a single language server instance!
Adds a few optimisations, tests, etc as well.

This had previously been merged in a way that caused issues, but this should resolve those issues.

Revert "Revert "feat: support vscode multi-root workspaces (#2594)" (#2612)" (#2616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants