Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changeset & publishing fix for LSP bugfix #2623

Merged
merged 2 commits into from
Aug 2, 2022
Merged

changeset & publishing fix for LSP bugfix #2623

merged 2 commits into from
Aug 2, 2022

Conversation

acao
Copy link
Member

@acao acao commented Aug 1, 2022

If a .graphql or .gql file is not found in includes or documents it seems to cause a warning sometimes when handled by the message processor, but in the language service, a missing project for a graphql file seems to actually crash the server. This appeared to fix the issue in the case where I could reproduce it.

This error is completely unnecessary! I don't know why we ever showed it. It seems I added it by accident during the typescript migration.

for now, when schema information isn't present we just no-op. eventually I would like to offer a lot more schemaless features, in new major versions of the language services where we refactor the interfaces

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022

🦋 Changeset detected

Latest commit: 3ce502b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-server Patch
vscode-graphql Patch
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #2623 (3ce502b) into main (2d91916) will increase coverage by 3.78%.
The diff coverage is 23.84%.

@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   65.70%   69.49%   +3.78%     
==========================================
  Files          85       71      -14     
  Lines        5106     4206     -900     
  Branches     1631     1411     -220     
==========================================
- Hits         3355     2923     -432     
+ Misses       1747     1278     -469     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.66% <5.66%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 47.61% <66.66%> (+0.63%) ⬆️
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 99 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@acao acao changed the title Fix bug with server exiting early on .graphql and .gql files Fix bug with server exiting early on .graphql and .gql files with url schema Aug 2, 2022
@acao acao added the lsp-server graphql-language-service-server label Aug 2, 2022
schema lsp introspection should work again.

swap out test mock as `@graphql-tools/url-loader` replaced `cross-undici-fetch` with `@whatwg-node/fetch`
@acao acao changed the title Fix bug with server exiting early on .graphql and .gql files with url schema changeset for LSP bugfix Aug 2, 2022
@acao acao changed the title changeset for LSP bugfix changeset & publishing fix for LSP bugfix Aug 2, 2022
@acao acao merged commit 12cf4db into main Aug 2, 2022
@acao acao deleted the lsp-bug branch August 2, 2022 11:15
@acao acao mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp-server graphql-language-service-server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant