Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set a prefix for data stored in localStorage #28

Merged
merged 1 commit into from
Sep 9, 2015

Conversation

skevy
Copy link
Contributor

@skevy skevy commented Sep 5, 2015

I needed this on my electron wrapper around GraphiQL...but I think it could be useful to others if they're embedding GraphiQL in an application that uses localStorage already.

@asiandrummer
Copy link
Contributor

Good one - thanks!

asiandrummer added a commit that referenced this pull request Sep 9, 2015
Add the ability to set a prefix for data stored in localStorage
@asiandrummer asiandrummer merged commit 3c315aa into graphql:master Sep 9, 2015
@leebyron
Copy link
Contributor

leebyron commented Sep 9, 2015

Would it be a better API to be able to provide a storage instance as a prop? That would allow switching up local/session storage, mocking storage for tests, or doing any number of other things including this.

@leebyron
Copy link
Contributor

leebyron commented Sep 9, 2015

Prefixing the names used is a great idea none the less

leebyron added a commit that referenced this pull request Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants