Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo - /* GraphQL */ not /* GraphiQL */! #2849

Merged
merged 2 commits into from
Nov 3, 2022
Merged

docs: typo - /* GraphQL */ not /* GraphiQL */! #2849

merged 2 commits into from
Nov 3, 2022

Conversation

acao
Copy link
Member

@acao acao commented Oct 28, 2022

huge typo. caused this user bug #2843 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: 06d7498

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
vscode-graphql-syntax Patch
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ADTC
Copy link

ADTC commented Oct 29, 2022

@acao I should have mentioned that I had actually tried the different spelling and it still didn't work:

image

But this version works:

image

So does it have to be positioned after the equals (=) sign? This is a .js file btw (not .ts).

@acao
Copy link
Member Author

acao commented Oct 29, 2022

@ADTC very good question - thanks for asking! both should work. looks like the regex for the syntax highlighting for case 1 is broken, then! Are you able to see validation/autocompletion even without highlighting in case 1? I will check later today

@ADTC
Copy link

ADTC commented Oct 29, 2022

@acao I'm sorry, but I'm only using the syntax highlighting extension right now. Hope you can check that on your end. Thank you!

@acao acao merged commit 9b98c1b into main Nov 3, 2022
@acao acao deleted the typo-fix branch November 3, 2022 22:41
This was referenced Nov 3, 2022
@ADTC
Copy link

ADTC commented Nov 4, 2022

Hope you managed to check. But it's okay. I kinda like the second version TBH. It doesn't take up one extra line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants