-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vscode-graphql] fix Svelte support #2861
Conversation
🦋 Changeset detectedLatest commit: 06d3cb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@aloker one missing piece - just need to add otherwise, the langauge server will pick up svelte files, but do nothing with them also as per the comments:
|
I signed the CLA and added the missing change and the changeset. |
thank you @aloker ! I will now merge the release PR once it's created |
@aloker latest @0.8.1 is the fix version. awesome work. I'll add more comprehensive tests because I suspect the vue parser might fail with more advanced attribute binding usage, but if it works fine for you and the svelte community then that's awesome! |
That's 0.8.2, right? I'll have to test it on an actual project. Thanks for the quick merge & release! |
Fixes #2857
The LSP server wasn't registered for svelte files.
Note: the PR does not have tests