-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(@graphiql/plugin-code-exporter): Fix Typo #2864
Conversation
🦋 Changeset detectedLatest commit: fe679ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Just a nit about changeset
"@graphiql/plugin-code-exporter": patch | ||
--- | ||
|
||
chore(@graphiql/plugin-code-exporter): Fix Typo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's just the README, we don't need a changeset for that (we don't need to publish a new version just because of a typo 😅 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But otherwise people reading the README on npm won’t get the update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point @LekoArts - especially because it's currently a standalone workspace, it won't get another release until there's another changeset to just this plugin. it seems excessive but I understand why from a release tooling automation standpoint
I think it's fair to consider a code example typo to be necessary for a patch release for sure. Maybe small spelling issue elsewhere in the docs, but a broken link or broken example should necessitate a patch release for npm and other registries
thank you @LekoArts ! |
Small typo fix in the README