-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to get vscode working in an e2e runner #3288
base: main
Are you sure you want to change the base?
Conversation
|
The latest changes of this PR are not available as canary, since there are no linked |
"examples/monaco-graphql-nextjs", | ||
"examples/monaco-graphql-react-vite" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it to test removing unused languages and avoid regressions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries, this PR will take a long while before it will be stable enough for review even! I expect to do a significant rebase next week
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3288 +/- ##
==========================================
+ Coverage 56.40% 56.48% +0.07%
==========================================
Files 109 109
Lines 5159 5191 +32
Branches 1407 1407
==========================================
+ Hits 2910 2932 +22
- Misses 1825 1835 +10
Partials 424 424
|
this is the closest I can get - if you follow the console log statements through the call stack, we are able to find the extension but not activate it. I then went so far as to disable most of the logic in
extension#activate()
to no avail - the activate() function is never called! the result is the same when i use thetsc
dist instead of the esbuild output, as the extension originally used before merging with the monorepo - the activate() function is never called when ext.activate() is invoked in the test helperthis setup is based on the lsp-sample
going to try some alternative test runners tomorrow, such as
vscode-extension-tester
, however these don't clearly document how to test LSP functionality