Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to get vscode working in an e2e runner #3288

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

attempt to get vscode working in an e2e runner #3288

wants to merge 6 commits into from

Conversation

acao
Copy link
Member

@acao acao commented Jun 26, 2023

this is the closest I can get - if you follow the console log statements through the call stack, we are able to find the extension but not activate it. I then went so far as to disable most of the logic in extension#activate() to no avail - the activate() function is never called! the result is the same when i use the tsc dist instead of the esbuild output, as the extension originally used before merging with the monorepo - the activate() function is never called when ext.activate() is invoked in the test helper

image

this setup is based on the lsp-sample

going to try some alternative test runners tomorrow, such as vscode-extension-tester, however these don't clearly document how to test LSP functionality

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: 658d7a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@acao
Copy link
Member Author

acao commented Jun 26, 2023

made more progress by switching to insiders build, dist, adding fixture files that will trigger activation events, and it worked!
the extension activated, but now the language-service client is causing this error

image

Comment on lines -10 to -11
"examples/monaco-graphql-nextjs",
"examples/monaco-graphql-react-vite"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to test removing unused languages and avoid regressions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, this PR will take a long while before it will be stable enough for review even! I expect to do a significant rebase next week

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #3288 (34bf19b) into main (2f15e20) will increase coverage by 0.07%.
The diff coverage is 67.56%.

❗ Current head 34bf19b differs from pull request most recent head 658d7a1. Consider uploading reports for the commit 658d7a1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3288      +/-   ##
==========================================
+ Coverage   56.40%   56.48%   +0.07%     
==========================================
  Files         109      109              
  Lines        5159     5191      +32     
  Branches     1407     1407              
==========================================
+ Hits         2910     2932      +22     
- Misses       1825     1835      +10     
  Partials      424      424              
Impacted Files Coverage Δ
...hql-language-service-server/src/findGraphQLTags.ts 82.40% <ø> (ø)
...ql-language-service-server/src/MessageProcessor.ts 47.80% <66.66%> (+1.58%) ⬆️
...raphql-language-service-server/src/GraphQLCache.ts 50.88% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants