-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add astro support for VSCode extension #3475
Conversation
🦋 Changeset detectedLatest commit: deccc6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8d0ed2d
to
0b16e7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work! you even covered the esbuild script, very comprehensive, thank you!
@XiNiHa just a few issues with dependencies, spelling and linting to clear up it looks like |
I'm about to merge a refactor for all of this that you will appreciate i'm sure, though it will cause a merge conflict |
@XiNiHa enjoy! let me know if you want me to redo it |
Sorry for being late to fix things up ;( I'll try to look at stuffs around this weekend |
@XiNiHa no worries, take your time! also I improved the grammars a bit. let me know if you want to pair on this or have any questions. |
5a798e0
to
c776e7e
Compare
The language server doesn't work due to ardatan/graphql-tools#5781 not being merged yet. |
@XiNiHa we have our own code parsing currently, but graphql-tools are also parsing files on their own, we don't use that result |
two things!
|
Looks like a typo in the package.json of |
awesome work! sidenote: i think the issue with svelte2tsx is twofold - the language server needs to specify typescript as a dependency so that it works in non vscode contexts, and with vscode, we need to upgrade vsce as you have done and mark typescript as external. if we try to make it internal to the esbuild bundle it breaks as well. i can show you how to debug definitively - the vscode extension runner does not reflect the esbuild bundled state |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
- Coverage 55.94% 55.74% -0.21%
==========================================
Files 113 114 +1
Lines 5291 5312 +21
Branches 1441 1444 +3
==========================================
+ Hits 2960 2961 +1
- Misses 1903 1923 +20
Partials 428 428
|
@XiNiHa this looks great! I will go ahead and merge, and then test the .vsix bundle manually just to be 100% certain. I think we can merge this and fix the svelte parsing in a single release |
I will take care of adding the tests in a follow up PR, but I might ping you later to make sure I've covered all the cases |
Adds Astro syntax grammar support, language server parsing support, and misc wirings.