use latest typescript version in lsp server

[acao]

make sure to use the latest version of typescript. i get confused with the autocomplete and copilot, oops!

[changeset-bot]

🦋 Changeset detected

Latest commit: 50555bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
graphql-language-service-server	Patch
vscode-graphql	Patch
graphql-language-service-cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.3.31-canary-d1f52525.0
graphql-language-service-server@2.11.9-canary-d1f52525.0

[samchungy]

Hey @acao my vscode has been alerting me that this plugin is crashing non stop since the latest 2 PRs.

0.8.22 seems to be fine

Error: Cannot find module 'typescript'
Require stack:
- /Users/samc/.vscode/extensions/graphql.vscode-graphql-0.8.24/out/server/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1129:15)
    at Module._load (node:internal/modules/cjs/loader:974:27)
    at f._load (node:electron/js2c/asar_bundle:2:13377)
    at Module.require (node:internal/modules/cjs/loader:1195:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at /Users/samc/.vscode/extensions/graphql.vscode-graphql-0.8.24/out/server/index.js:4355:5291
    at /Users/samc/.vscode/extensions/graphql.vscode-graphql-0.8.24/out/server/index.js:1:264
    at /Users/samc/.vscode/extensions/graphql.vscode-graphql-0.8.24/out/server/index.js:4441:2810
    at /Users/samc/.vscode/extensions/graphql.vscode-graphql-0.8.24/out/server/index.js:1:264
    at /Users/samc/.vscode/extensions/graphql.vscode-graphql-0.8.24/out/server/index.js:4441:4643 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/samc/.vscode/extensions/graphql.vscode-graphql-0.8.24/out/server/index.js'
  ]
}

It looks like typescript should be an explicit dependency for vscode-graphql?

[samchungy]

graphiql/packages/vscode-graphql/esbuild.js

Line 52 in f5ade68

'typescript',

Ah it looks like this might be the cause? ^

[acao]

perhaps, let's try without that. I can't re-create the issue locally, because the runner doesn't expose this issue. i will upload an VSIX here

[acao]

@samchungy can you try this version to verify that disabling the external rule works?

https://drive.google.com/file/d/15v-tdLbu_z69O0qWpysfQfMI69Hk1SpO/view?usp=sharing

We're no longer allowed to upload vsix files to github comments it appears, understandably so

[acao]

no, that does not work either. we have to revert this svelte PR it looks like

[acao]

@samchungy 0.8.25 should be the fix version, it will be released in a few minutes. I manually tested it. It degrades svelte parsing significantly until we figure out a better solution.

[samchungy]

Much appreciated 🙇. It's pretty late where I am so I'll give it a spin tomorrow :)

[samchungy]

@acao 0.8.25 seems to work fine! Thanks for the speedy fix once again! 😄