add defaultTheme prop to specify default theme if no previous value stored #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 238edcd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3619 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 121 121
Lines 7017 7017
Branches 2268 2244 -24
=======================================
Hits 4722 4722
Misses 2278 2278
Partials 17 17
|
dimaMachina
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
thanks, lgtm, added some e2e tests, maybe in some major we could migrate to next-themes and avoid creating wheel
This was referenced Aug 15, 2024
Merged
dimaMachina
added a commit
that referenced
this pull request
Aug 15, 2024
…tored (#3619) * add defaultTheme prop to specify default theme if no previous value in storageContext * yoyo --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is too big of a change but would love to have a way to provide an optional prop to show GraphiQL in a specific theme.