Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/3] [v3] migrate graphiql from jest to vitest #3825

Merged
merged 14 commits into from
Dec 14, 2024
Merged

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Dec 13, 2024

Part of #3821

graphiql in tests should rely on build version of @graphiql/react and not on src (because react-compiler compiles @graphiql/react source code) and I had tests which were failed

I also:

  • updated vitest to latest
  • updated @testing-library/react to latest
  • removed @types/testing-library__jest-dom (no longer needed since last version of @testing-library/react include types

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 6f6f481

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
codemirror-graphql Minor
graphiql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.49%. Comparing base (9f725b8) to head (503cf0a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3825      +/-   ##
==========================================
- Coverage   65.32%   58.49%   -6.84%     
==========================================
  Files         122      109      -13     
  Lines        7003     6115     -888     
  Branches     2260     1907     -353     
==========================================
- Hits         4575     3577     -998     
- Misses       2411     2522     +111     
+ Partials       17       16       -1     
Files with missing lines Coverage Δ
packages/codemirror-graphql/src/hint.ts 95.00% <ø> (ø)

... and 39 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Dec 13, 2024

The latest changes of this PR are available as canary in npm (based on the declared changesets):

codemirror-graphql@2.2.0-canary-c3c3b243.0
graphiql@3.8.0-canary-c3c3b243.0
@graphiql/plugin-code-exporter@3.1.4-canary-c3c3b243.0
@graphiql/plugin-explorer@3.2.4-canary-c3c3b243.0
@graphiql/react@0.27.1-canary-c3c3b243.0

@dimaMachina dimaMachina requested a review from acao December 13, 2024 18:37
Base automatically changed from do-not-bundle-codemirror to main December 14, 2024 12:21
@dimaMachina dimaMachina merged commit 7cdcabf into main Dec 14, 2024
2 checks passed
@acao acao mentioned this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant