[RFC] Treat locate command response as path:line:column #3895
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our intention in Relay was for the response from the locate command to be treated as `path:line:column` to match the convention of path strings in CLI output used by most tools. For example, paths in stack traces or errors in compiler output. This convention is a de facto standard understood by many terminal emulators. This means if a server implements a locate command it should be useful in GraphQL LSPs (like this one or Relay's) and also at the CLI, where a user could manually invoke the command and then cmd+click the result to jump to the correct location in their editor.
|
|
I opened a similar PR here: #3891 I think there is still a discrepancy here between 1 and 0 indexed line numbers |
|
Lol, I'm too slow. You even cced me. I'll close this in favor of yours. |
|
@captbaritone are you good with closing this PR in favor of #3891? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our intention in Relay was for the response from the locate command to be treated as
path:line:columnto match the convention of path strings in CLI output used by most tools. For example, paths in stack traces or errors in compiler output.This convention is a de facto standard understood by many terminal emulators. This means if a server implements a locate command it should be useful in GraphQL LSPs (like this one or Relay's) and also at the CLI, where a user could manually invoke the command and then cmd+click the result to jump to the correct location in their editor.
I'm not sure what if any tests/docs etc will need to change here, but I figured this PR could start the conversation.
Screen.Recording.2025-04-25.at.9.25.20.AM.mov