Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copyright to GraphQL Contributors, License to MIT #849

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

acao
Copy link
Member

@acao acao commented Jun 14, 2019

@leebyron @caniszczyk this should be it. Creating this PR in the official graphiql instead of the fork this time so it's part of the PR history

@acao
Copy link
Member Author

acao commented Jun 17, 2019

@caniszczyk can you review this today so we can merge the ide monorepo at the WG tomorrow?

@IvanGoncharov
Copy link
Member

@acao In graphql-js, I just removed copyright headers see: graphql/graphql-js#1960
Here is motivation for doing that: graphql/graphql-js#1960 (comment)
I think would be great to do the same here to have consistency in all graphql/* projects.
What do you think?

@acao
Copy link
Member Author

acao commented Jun 17, 2019

@IvanGoncharov I agree that this makes sense. I did this in a previous PR, but then @caniszczyk asked me to re-introduce the headers with a different copyright message.

@acao acao requested review from leebyron and caniszczyk June 17, 2019 23:37
@IvanGoncharov
Copy link
Member

I did this in a previous PR, but then @caniszczyk asked me to re-introduce the headers with a different copyright message.

@acao Totally makes sense in this case. Thanks for sharing context around this decision.

@acao
Copy link
Member Author

acao commented Jun 18, 2019

@caniszczyk can you give this a review so we can merge for the WG meeting today?

@caniszczyk
Copy link

LGTM

@acao acao merged commit 803ef5a into graphql:ide-monorepo Jun 18, 2019
@acao
Copy link
Member Author

acao commented Jun 18, 2019

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants