-
Notifications
You must be signed in to change notification settings - Fork 20
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When checking the Accept header the charset is expected to be utf8 not utf-8 #120
Comments
enisdenjo
pushed a commit
that referenced
this issue
Apr 10, 2024
## [1.22.1](v1.22.0...v1.22.1) (2024-04-10) ### Bug Fixes * **audit/render:** Omit `set-cookie` header and html body ([#116](#116)) ([1c5c744](1c5c744)) * **handler:** Support both utf-8 and utf8 charsets ([94100d6](94100d6)), closes [#120](#120) * **use:** Set request readable encoding to utf-8 ([50d3bcd](50d3bcd)), closes [#118](#118)
🎉 This issue has been resolved in version 1.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you for bringing this up! v1.22.1 now includes a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behaviour
A request with the HTTP header:
is accepted as a GraphQL request
Actual Behaviour
The request is rejected with:
Debug Information
I think the check here is wrong and should be looking for
utf-8
notutf8
.https://github.com/graphql/graphql-http/blob/v1.22.0/src/handler.ts#L593
The text was updated successfully, but these errors were encountered: