Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphqlSync doesn't support mutations #1195

Closed
dkuznetsov44 opened this issue Jan 9, 2018 · 0 comments
Closed

graphqlSync doesn't support mutations #1195

dkuznetsov44 opened this issue Jan 9, 2018 · 0 comments
Labels
bug

Comments

@dkuznetsov44
Copy link

executeFields (for queries) returns MaybePromise
executeFieldsSerially (for mutations) returns Promise and this is not "sync"

https://github.com/graphql/graphql-js/blob/master/src/execution/execute.js#L399

Could you please rewrite executeFieldsSerially to return MaybePromise also?

Thanks! :)
leebyron added a commit that referenced this issue Jan 10, 2018
@leebyron
Execute serially supporting sync execution.
51e44db 
Refactors executeFieldsSerially to return MaybePromise

Fixes #1195
@leebyron leebyron mentioned this issue Jan 10, 2018
Merged
leebyron added a commit that referenced this issue Jan 10, 2018
@leebyron
Execute serially supporting sync execution.
e756c72 
Refactors executeFieldsSerially to return MaybePromise

Fixes #1195
leebyron added a commit that referenced this issue Jan 12, 2018
@leebyron
Execute serially supporting sync execution. (#1198)
1158cd4 
Refactors executeFieldsSerially to return MaybePromise

Fixes #1195
This was referenced May 28, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leebyron @dkuznetsov44