Flow errors from imported npm package in buildAstSchema

[TxHawks]

Using graphql-js version 14.0.2 and Flow version 0.87.0, Flow throws the following errors:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/graphql/utilities/buildASTSchema.js.flow:363:9

Missing type annotation for V. V is a type parameter declared in function [1] and was implicitly
instantiated at call of keyValMap [2].

     node_modules/graphql/utilities/buildASTSchema.js.flow
     360│     def: ObjectTypeDefinitionNode | InterfaceTypeDefinitionNode,
     361│   ) {
     362│     return def.fields
 [2] 363│       ? keyValMap(
     364│           def.fields,
     365│           field => field.name.value,
     366│           field => this.buildField(field),
     367│         )
     368│       : {};
     369│   }
     370│

     node_modules/graphql/jsutils/keyValMap.js.flow
 [1]  29│ export default function keyValMap<T, V>(
      30│   list: $ReadOnlyArray<T>,
      31│   keyFn: (item: T) => string,
      32│   valFn: (item: T) => V,
      33│ ): ObjMap<V> {


Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/graphql/utilities/buildASTSchema.js.flow:372:12

Missing type annotation for V. V is a type parameter declared in function [1] and was implicitly
instantiated at call of keyValMap [2].

     node_modules/graphql/utilities/buildASTSchema.js.flow
     369│   }
     370│
     371│   _makeInputValues(values: $ReadOnlyArray<InputValueDefinitionNode>) {
 [2] 372│     return keyValMap(
     373│       values,
     374│       value => value.name.value,
     375│       value => this.buildInputField(value),
     376│     );
     377│   }
     378│
     379│   _makeInterfaceDef(def: InterfaceTypeDefinitionNode) {

     node_modules/graphql/jsutils/keyValMap.js.flow
 [1]  29│ export default function keyValMap<T, V>(
      30│   list: $ReadOnlyArray<T>,
      31│   keyFn: (item: T) => string,
      32│   valFn: (item: T) => V,
      33│ ): ObjMap<V> {


Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/graphql/utilities/buildASTSchema.js.flow:399:9

Missing type annotation for V. V is a type parameter declared in function [1] and was implicitly
instantiated at call of keyValMap [2].

     node_modules/graphql/utilities/buildASTSchema.js.flow
     396│
     397│   _makeValueDefMap(def: EnumTypeDefinitionNode) {
     398│     return def.values
 [2] 399│       ? keyValMap(
     400│           def.values,
     401│           enumValue => enumValue.name.value,
     402│           enumValue => this.buildEnumValue(enumValue),
     403│         )
     404│       : {};
     405│   }
     406│

     node_modules/graphql/jsutils/keyValMap.js.flow
 [1]  29│ export default function keyValMap<T, V>(
      30│   list: $ReadOnlyArray<T>,
      31│   keyFn: (item: T) => string,
      32│   valFn: (item: T) => V,
      33│ ): ObjMap<V> {

As a quick fix, I've added .*/node_modules/graphql/jsutils/keyValMap.js.flow to my .flowconfig, but this is far from ideal...

[alizhdanov]

The same for me, thanks for the workaround. I think it's already fixed, but not yet released - 0ea7b51

[IvanGoncharov]

The same for me, thanks for the workaround. I think it's already fixed, but not yet released - 0ea7b51

@alizhdanov Correct, you can test using this package:
https://github.com/graphql/graphql-js#want-to-ride-the-bleeding-edge

@mjmahone Can we release 14.1.0 as is to publish fix for this issue and #1518 ?
I think we can push all other planned items to 14.2.0.
What do you think?

[mjmahone]

I'd be happy pushing 14.2.0 this week. I'll try to ping @leebyron to make sure he's aware.

[IvanGoncharov]

@mjmahone @leebyron It would be great to update tokens inside:

graphql-js/.travis.yml

Lines 44 to 51 in 97568af

	secure: tCIGE/3CLOQlC49i/9ug42ILQjZnMOrSjyjdHkqmTVN5q9p9bljjziXQbNxYfVPYa9icICnVnI4c5psjktW+vwaz2WJAJhpWD6P3YGcpmKjjgPKKHKWOcXvq3HdIzH7DIbXyVtE0QLpV5zgbyxglD96vYScO9dvGeAhTGY/9qJaDvVkLOZ+6YpKiTwZlZcyPHlD1tbxzd4NytJgIsi7CedFdfATAmOyVsot1NRZr5q3oV0aXFjJRnhBQ3RtykGgGHtXEWYTNhAmYxcIwezYRYXLxtlkbrlwxixpKAdJr/UXHg6amplkaHtCopi+QChPQRmdndcDC6F+e2nFHut6BCi14Jnbvf7seaqWrmh0uqdopqMJFRP3OBc9lXZf3hljVKV9+iVbWNjxoUB7ezurOOEpgkXleJ5AO2o3u8oYh3OFfLYu7E1a4uSjfe4nP/zi+th+wvS4Wy2UWqErYFUMotMyStS/vllXUpK7pl+Qt59MUVHB8YzREyCVKxakQ/uvNvY+bzKf4sM8UJ/Dqnl3MaAjLG3rWZbFyzXdaJnRGdTeFK2lpz8nrfJEDzLIQX5ZC88yR30WahrRjAhLnnq0V1fYp0wLbLxs4SdN+tuMRlkzQhQEYYDYa5osgEo2C+O4D/H9F7GWHHJp9zPE+hMi5+ZwTPKHkln4/AqrABUKOk78=
	on:
	branch: master
	tags: true
	env:
	global:
	secure: "uUjOV39iCLSLtShQfKk9AelIu2PqyKf8dYu4rqVcL5Y9yCHdds1KYysVgCx9XhndrugHNCXWzT/sKDS8voc/NRsfycnvdCIvu+dtBwf9lCHGcMyABFpvsjQfKTGyMCbYNDO8Hd/OQqHCFVj1lh4aNGev8tGqpJoMEDPdQbDKsvMVKWfo9QraXYYK7yh7U2vbidAV+YBj/e3VFfR2UQ+OECHxyxFGxWMbyTF8qRZ7JUsgCaJ82zrx0A7VoEJ6BeXxzhYDPuh3QTON9bXiJpWR/QcsKZNQ7d6Dxf06yo4XQDU9igxe6qst41Hj3IiZzLCyucoPXvoRsbmUcsAVdF4PWq3fnHUmyjRwOMcTjPd2SM4FPJpwnSGZEpstzKSJ3pDzpgRGsF7ai5nGNCes6RCi4AUf96GTjt0JAD+AXwD7mrGlcn4oi0m6r1GcNhDOFsBEgFqz26FXUFQcAqrHzZvsqvG01Cs5pAFMUIEpCyCrkDKClc/LWjJoVInDEVCwGqZk6Qz2XroYjFs25m+aB3ycSIN1qgkTg6szMO76tds4YtL8JDHaAXDbvXAk8YRYbQCAIFQVaIpkp8R1kJa++dP8Q3j/lwAkz+57XJ5KPRlLh7KMqF1joTGKptA0c2vD0sees2RxPrcZGmp6eaOLy3JhQmXfPaRLLpiK+plz6T25f7Y="

That way we will be able to do automatic releases and release bugfixes faster.

[wincent]

That way we will be able to do automatic releases and release bugfixes faster.

That would be nice. :-)

[mgrip]

Seems like .89 was released but this is still broken?

[IvanGoncharov]

@mjmahone @leebyron Can you please update NPM token so we can release RC?

Currently we block Flow users from updating Flow.
More recent example:
4cdc8e2#commitcomment-31933578

Could you please release this change so we are not blocked on it? 🙂

[IvanGoncharov]

@mjmahone just published 14.1.0 so this issue should be fully resolved.

[wincent]

And I see 14.1.1 fast-followed. Thanks!