-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coveralls broken for Node 11 #1682
Comments
@Neitsch Thanks for the opening issue 👍 I did a quick search and it looks like Babel and some other projects switched to codecov |
@mjmahone I still don't see reports showing up. Could nyc be broken, so that the coverage report does not work? I believe coveralls was complaining about an empty report before we switched. |
@Neitsch I finally manage to make it work: |
@IvanGoncharov should we switch back to coveralls in that case? Or perhaps upload to both for the time being? We have a lot of historical information still in coveralls, so it may be worth generating both reports if possible. |
@mjmahone Coveralls was lagging from time to time and it forced me to manually review Travis logs every time + it has a few annoying UI quirks that were constantly pestering me. But most importantly codecov has some very useful features that coveralls lacks. For example, ability to have a separate report for Flow type coverage: facebook/flow#3231
All historical data will stay on Let's try |
@IvanGoncharov already found this, but adding tracking here: Coveralls appears to be broken for Node 11 on Travis. Sample Travis log: https://travis-ci.org/graphql/graphql-js/jobs/482864463
At this point it is unclear why Node 11 specifically is broken.
The text was updated successfully, but these errors were encountered: